Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigint: Remove redundant ">= 3" check for Modulus. #2184

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

briansmith
Copy link
Owner

As we require the modulus to be multiple limbs long, its value cannot be less than 3.

As we require the modulus to be multiple limbs long, its value cannot
be less than 3.
@briansmith briansmith self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (01742ba) to head (1c861df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2184   +/-   ##
=======================================
  Coverage   96.94%   96.95%           
=======================================
  Files         154      154           
  Lines       20238    20216   -22     
  Branches      464      462    -2     
=======================================
- Hits        19620    19600   -20     
+ Misses        512      511    -1     
+ Partials      106      105    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith merged commit 9baba60 into main Dec 11, 2024
158 checks passed
@briansmith briansmith deleted the b/limbs-less-than-limb branch December 11, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant