aes: Clarify empty buffer handling in AES-CTR. #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
=======================================
Coverage 96.92% 96.93%
=======================================
Files 154 154
Lines 20235 20234 -1
Branches 461 461
=======================================
+ Hits 19612 19613 +1
Misses 518 518
+ Partials 105 103 -2 ☔ View full report in Codecov by Sentry. |
At one point we required `f` to be able to handle empty inputs, but a later refactoring changed that, and added the necessary check before calling `f`, but we forgot to update the comment. To further clarify things, use `NonZeroU32` when incrementing the counter, since a zero increment would result in a reused counter.
briansmith
force-pushed
the
b/clarify-zero-aes
branch
from
23f4f58 to
4eca639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point we required
fto be able to handle empty inputs, but a later refactoring changed that, and added the necessary check before callingf, but we forgot to update the comment.To further clarify things, use
NonZeroU32when incrementing the counter, since a zero increment would result in a reused counter.