aes-gcm internals: Clarify in_out processing.
#2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the invariants in `Overlapping`. Consistently use `Overlapping::new` for checking of `src`. Clarify the assumptions we're making about the assembly function's return value. Consistently use `in_out` for `Overlapping`s and `in_out_slice` for slices.
Use `in_out` for `Overlapping` values and `in_out_slice` for slices. Use `Overlapping::new` as the sole way of bounds checking `src`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2205 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 158 158
Lines 20256 20265 +9
Branches 454 454
=======================================
+ Hits 19682 19691 +9
Misses 469 469
Partials 105 105 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.