This repository has been archived by the owner on Nov 15, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 21
Allow multiple variables #15
Open
taylonr
wants to merge
16
commits into
brpaz:master
Choose a base branch
from
taylonr:allow-multiple-variables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, open it in the active editor.
…hat ALL variables are defined.
Load file on success
Use the name the user supplied for the template.
Allow template to be edited
Thanks @taylonr, I'll test it as I'm having exactly the same problem |
Is there any excepted date to the next release with this feature? |
nicoesiea
suggested changes
Sep 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the template file has multiple variable declarations, the user was only asked to supply the last variable. Because only one variable was asked to be defined, the
Promise.all
never gets resolved and the file doesn't get created.By extracting to a recursive function, the user will now be prompted to enter a value for every variable, and only after they're all supplied will the file be written.
An example template file used to test this: