Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace creating handle with new adapters #205

Merged
merged 7 commits into from
Jan 20, 2025
Merged

refactor: replace creating handle with new adapters #205

merged 7 commits into from
Jan 20, 2025

Conversation

apteryxxyz
Copy link
Member

With this new way of using environment variables at the top level in Cloudflare, the need for a client factory is no longer needed.

  • replaces the createHandle function with a new way of working with Cloudflare Workers
  • combines Next.js and Cloudflare adapters into single fetch adapter (other adapters also use it under the hood)
  • updates templates, jsdocs, and documentation

@apteryxxyz apteryxxyz requested review from a team and thewilloftheshadow as code owners January 19, 2025 03:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6f551dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@buape/carbon Minor
create-carbon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added p:carbon The carbon package p:create-carbon The create-carbon package labels Jan 19, 2025
thewilloftheshadow
thewilloftheshadow reviewed Jan 19, 2025
View reviewed changes
Copy link
Member

@thewilloftheshadow thewilloftheshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like! Going to look at the site later tonight before approving/merging

@thewilloftheshadow thewilloftheshadow merged commit 626f3c3 into main Jan 20, 2025
10 of 11 checks passed
@thewilloftheshadow thewilloftheshadow deleted the apteryxxyz/new-handling branch January 20, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilloftheshadow thewilloftheshadow thewilloftheshadow left review comments

Assignees
No one assigned
Labels
p:carbon The carbon package p:create-carbon The create-carbon package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apteryxxyz @thewilloftheshadow