feat: command permissions #212
Conversation
🦋 Changeset detectedLatest commit: fe259e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thewilloftheshadow
force-pushed
the
shadow/command-permissions
branch
from
b2d91e9 to
268b88d
Compare
| * The default permission that a user needs to have to use this command. | ||
| * This can be overridden by server admins. | ||
| */ | ||
| permission?: (typeof Permission)[keyof typeof Permission] |
There was a problem hiding this comment.
This type resolves to just bigint anyway (so can use bit manipulation), but is any reason this isn't an array that can later be resolved to a bigint?
There was a problem hiding this comment.
I'm still not sure how I feel about this but I think it's the best way.
Permission reexports the enum PermissionFlagBits from discord-api-types, which is the only spot all permissions are defined.
The alternative that we could do is maintain our own list, separate from discord-api-types.
I was trying at one point to type it as keyof typeof Permission so that users would just pass "ManageGuild", etc, but it was being typed as a string and not const so that wasn't working cleanly
There was a problem hiding this comment.
While keyof typeof Permission seems to work as expected for me, I was more referring to just
permissions?: ((typeof Permission)[keyof typeof Permission])[]
and then later use reduce in the serialize method to combine those bits
this.permissions ? this.permissions.reduce((a, p) => a | p, 0n).toString() : null
thewilloftheshadow
force-pushed
the
shadow/command-permissions
branch
from
a8d44f8 to
fe259e4
Compare
Closes #155