Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the create inlet help message #8449

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ivor11
Copy link
Contributor

@ivor11 ivor11 commented Sep 9, 2024

Current behavior

Current rust doc comment for creating a TCP inlet:
Create TCP Inlets

Proposed changes

Proposed rust doc comment for creating a TCP inlet:
Create a TCP Inlet

Closes #6643

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@ivor11 ivor11 force-pushed the fix/create-tcp-inlet-docs branch 4 times, most recently from f48776d to b65de7f Compare September 9, 2024 23:13
@ivor11 ivor11 changed the title fix(create-tcp-inlet-docs): Create a TCP Inlet chore(create-tcp-inlet-docs): Create a TCP Inlet Sep 9, 2024
@ivor11 ivor11 marked this pull request as ready for review September 9, 2024 23:17
@ivor11 ivor11 requested a review from a team as a code owner September 9, 2024 23:17
@etorreborre
Copy link
Member

Hi @ivor11, can you please:

  • Check the commits convention and adjust your commit for this PR (note: chore: fix the create inlet help message is fine as a message)

  • Create a separate pull request to be added as a contributor?

@ivor11 ivor11 force-pushed the fix/create-tcp-inlet-docs branch from 5459c0f to 8044bf6 Compare September 14, 2024 12:44
@ivor11 ivor11 changed the title chore(create-tcp-inlet-docs): Create a TCP Inlet chore: fix the create inlet help message Sep 14, 2024
@ivor11
Copy link
Contributor Author

ivor11 commented Sep 14, 2024

Thanks @etorreborre,
I've edited the commit message as per your suggestion and created a PR for adding myself as a contributor #8462

@etorreborre
Copy link
Member

Hi @ivor11 you need to use the same email for your contributions as the one listed in your CLA acceptance. Can you please either change this PR commit or open a new CLA PR to fix your email address?

@ivor11 ivor11 force-pushed the fix/create-tcp-inlet-docs branch from 8044bf6 to 22d10b5 Compare September 17, 2024 23:48
@ivor11 ivor11 force-pushed the fix/create-tcp-inlet-docs branch from 22d10b5 to caf6f63 Compare September 17, 2024 23:49
@ivor11
Copy link
Contributor Author

ivor11 commented Sep 17, 2024

Hi @etorreborre,
I've fixed the email on the PR commit, could you please run the CI checks again

@ivor11
Copy link
Contributor Author

ivor11 commented Nov 14, 2024

Hi @etorreborre,
can you please run the checks again and merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ockam tcp-inlet create --help text (clap command)
2 participants