Correct shiftUpperValue() for d4 (Issue #6) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of shift_dice_faces() from the original dice.js had not been brought into this adaptation. I've attempted to port it over. It seems to work in my tests, but I am not 100% confident given I haven't fully understood the underlying code.
tim-duncan
reviewed
May 26, 2019
| @@ -206,6 +206,18 @@ class DiceObject { | |||
|
|
|||
| geometry.faces[i].materialIndex = materialIndex + 1; | |||
| } | |||
| if (this.values == 4 && toValue != fromValue) { | |||
There was a problem hiding this comment.
@liffiton, I see this working in most cases, but it fails where the && toValue != fromValue condition is met. Removing that restriction from the if seems to work in all cases that I have observed.
Suggested change
| if (this.values == 4 && toValue != fromValue) { | |
| if (this.values == 4) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of shift_dice_faces() from the original dice.js had not been brought into this adaptation. I've attempted to port it over. It seems to work in my tests, but I am not 100% confident given I haven't fully understood the underlying code.