Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for compiling on windows #4026

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

malytomas
Copy link
Contributor

small fixes:

D:\a\cage\cage\externals\wamr\wamr\core\shared\platform\windows\win_clock.c(15,1): error C2373: 'NtQueryTimerResolution': redefinition; different type modifiers [D:\a\cage\cage\build\externals\wamr\iwasm_static.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\um\winternl.h(713,1):
see declaration of 'NtQueryTimerResolution'

when compiling with visual studio for win32

D:\a\cage\cage\externals\wamr\wamr\core\shared\platform\windows\win_thread.c(96,9): error : call to undeclared function 'os_sem_destroy'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] [D:\a\cage\cage\build\externals\wamr\iwasm_static.vcxproj]

when compiling with clang on windows

@malytomas
Copy link
Contributor Author

I dont know what to do about the failed tests. The compilation has succeeded, but it failed to download some other files.

Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit ba75b8f into bytecodealliance:main Jan 17, 2025
390 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants