Pose Buffer Implementation #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Panda8188
commented
Jan 4, 2024
Panda8188
commented
- Implemented Pose Buffer using Array Deques (pairs) with a max size of 50 poses
- TODO: Implement Tests for pose buffer (not fully complete)
Implemented Pose Buffer using Array Deques (pairs) with a max size of 50 poses TODO: Implement Tests for posebuffer (not fully complete)
balghane
requested changes
Jan 10, 2024
| import edu.wpi.first.math.Pair; | ||
| import edu.wpi.first.math.geometry.Pose2d; | ||
| import edu.wpi.first.wpilibj.Timer; | ||
| public class PoseBuffer { |
There was a problem hiding this comment.
Also needs function to query an arbitrary timestamp, where we interpolate if it's within the range in the buffer, and return an error if the query is outside the range
There was a problem hiding this comment.
And this function should be tested.
Can we also check that these tests are run by GitHub ci?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.