Xd/dev #6
Open
Xd/dev #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in input for masked lm loss function
Fix internal hyperlink typo
Should be consistent with the fact that an uncased model is used
Update finetuning example in README adding --do_lower_case
Point typo fix
I tried to address huggingface#76 should be correct, but there's likely a more efficient way.
Correct assignement for logits in classifier example
Readme file links
Never split some texts.
It was modified similar to `run_classifier.py`, and Fixed to run properly even if without `--do_train` param.
Fix it to run properly even if without `--do_train` param.
Added Squad 2.0
…saving add do_lower_case arg and adjust model saving for lm finetuning.
The "default=True" makes args.do_lower_case always True.
```python
parser.add_argument("--do_lower_case",
default=True,
action='store_true')
```
dicts are not ordered in Python 3.5 or prior, which is a cause of huggingface#175. This PR replaces one with a list, to keep its order.
This PR adds missing backslashes in LM Fine-tuning subsection in README.md.
Importing unofficial TF models seems to be working well, at least for me. This PR resolves huggingface#50.
[bug fix] args.do_lower_case is always True
Fix documentation (missing backslashes)
lm_finetuning compatibility with Python 3.5
Fix importing unofficial TF models
(very) minor update to README
run_squad2 Don't save model if do not train
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RT