Merge pull request #426 from nils-a/feature/GH-422

(#422) Setting ActionUpdateThread to EDT
cake-build · May 8, 2024 · 7132f73 · 7132f73
2 parents b38b4cd + 805deb8
commit 7132f73
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/src/dotnet/Directory.Build.props b/src/dotnet/Directory.Build.props
@@ -6,7 +6,7 @@
         <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
         <DebugType>pdbonly</DebugType>
         <!-- will be injected by gradle at build -->
-        <SdkVersion Condition="'$(SdkVersion)' == ''">2024.1.0-eap03</SdkVersion>
+        <SdkVersion Condition="'$(SdkVersion)' == ''">2024.1.0</SdkVersion>
         <WaveVersion>$(SdkVersion.Substring(2,2))$(SdkVersion.Substring(5,1)).0.0</WaveVersion>
         <ResolveAssemblyWarnOrErrorOnTargetArchitectureMismatch>None</ResolveAssemblyWarnOrErrorOnTargetArchitectureMismatch>
     </PropertyGroup>
@@ -15,7 +15,7 @@
         <DebugType>full</DebugType>
         <DefineConstants>$(DefineConstants);TRACE;DEBUG;JET_MODE_ASSERT</DefineConstants>
     </PropertyGroup>
-    
+
     <ItemGroup>
         <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All" />
     </ItemGroup>

diff --git a/src/dotnet/cake-rider/CakeTaskCollectorStage.cs b/src/dotnet/cake-rider/CakeTaskCollectorStage.cs
@@ -12,7 +12,6 @@ namespace net.cakebuild;
 /// <summary>
 /// Used to update tasks after initial solution load.
 /// </summary>
-[DaemonStage(StagesAfter = new[] { typeof(FilteringHighlightingDaemonStage) })]
 public sealed class CakeTaskCollectorStage : CSharpDaemonStageBase
 {
     private readonly ICakeFrostingProjectsHost _host;

diff --git a/src/rider/gradle.properties b/src/rider/gradle.properties
@@ -9,16 +9,16 @@ pluginUntilBuild = 241.*
 # Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
 # See https://jb.gg/intellij-platform-builds-list for available build versions.
 # or https://data.services.jetbrains.com/products?fields=name,releases.downloads,releases.version,releases.build,releases.type&code=RD
-pluginVerifierIdeVersions = RD-2024.1-EAP1
+pluginVerifierIdeVersions = RD-2024.1
 
 platformType = RD
 # platformVersion Examples:
 #   Release:  2024.1
 #   EAP:      2024.1-EAP2-SNAPSHOT
 #   Nightly:  2024.1-SNAPSHOT
-platformVersion = 2024.1-EAP1-SNAPSHOT
+platformVersion = 2024.1
 # dotNetSdkVersion should be equivalent to platformVersion!
-dotNetSdkVersion = 2024.1-eap01
+dotNetSdkVersion = 2024.1.0
 platformDownloadSources = false
 # Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html
 # Example: platformPlugins = com.intellij.java, com.jetbrains.php:203.4449.22

diff --git a/src/rider/src/main/kotlin/net/cakebuild/actions/CakeTasksTreeAction.kt b/src/rider/src/main/kotlin/net/cakebuild/actions/CakeTasksTreeAction.kt
@@ -1,5 +1,6 @@
 package net.cakebuild.actions
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import net.cakebuild.shared.CakeDataKeys
@@ -10,6 +11,10 @@ abstract class CakeTasksTreeAction : AnAction() {
         return CakeDataKeys.TASKS_WINDOW.getData(e.dataContext)
     }
 
+    override fun getActionUpdateThread(): ActionUpdateThread {
+        return ActionUpdateThread.EDT
+    }
+
     class CollapseAll : CakeTasksTreeAction() {
         override fun actionPerformed(e: AnActionEvent) {
             val win = getWindow(e) ?: return