Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Vendors Page #503

Merged
merged 28 commits into from
Dec 8, 2023
Merged

For Vendors Page #503

merged 28 commits into from
Dec 8, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 4, 2023

closes #442
closes #499
closes #500
closes #496
closes #495

What this PR does

  • creates new page
  • adds newsletter sign up template
  • adds page to nav
  • add focus areas section
  • add header image area

https://deploy-preview-503--cal-itp-mobility-marketplace.netlify.app/for-vendors

@machikoyasuda machikoyasuda self-assigned this Dec 4, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 4, 2023 20:43
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for cal-itp-mobility-marketplace ready!

Name Link
🔨 Latest commit 58bb9a8
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-mobility-marketplace/deploys/6572498f06331400086e817e
😎 Deploy Preview https://deploy-preview-503--cal-itp-mobility-marketplace.netlify.app/for-vendors
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda machikoyasuda added this to the Provider Map Refresh milestone Dec 4, 2023
@machikoyasuda
Copy link
Member Author

This is the first PR for the For Vendors page - and is now ready for review. All subsequent PRs will go into this PR.

When this PR is approved, I will not merge it in yet. This PR will be merged at the very end, when all the PRs are done.

FYI @thekaveman @angela-tran

angela-tran
angela-tran previously approved these changes Dec 6, 2023
thekaveman
thekaveman previously approved these changes Dec 7, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📬

@machikoyasuda machikoyasuda changed the title For vendors page: Create new page, add newsletter For Vendors Page Dec 7, 2023
@thekaveman thekaveman self-requested a review December 7, 2023 01:16
@thekaveman thekaveman dismissed stale reviews from angela-tran and themself December 7, 2023 01:22

Will re-review complete page

@machikoyasuda
Copy link
Member Author

@thekaveman
Copy link
Member

Reviewing now but I'm pretty sure this is G2G!

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny fix that I didn't notice from the FAQ PR

src/for-vendors.html Outdated Show resolved Hide resolved
@mrose914
Copy link

mrose914 commented Dec 7, 2023

This looks great! I am awaiting a couple of small copy edits from Lev and Jon but will follow up once I have them (ETA in next hour or so).

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending any updates from @mrose914

@mrose914
Copy link

mrose914 commented Dec 8, 2023

Alright, let's ship it! I'll ticket any minor tweaks that come up after launch.

@machikoyasuda machikoyasuda merged commit fd3d192 into main Dec 8, 2023
3 checks passed
@machikoyasuda machikoyasuda deleted the feat/499-for-vendors-newsletter branch December 8, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants