fix: creating workflow reminders for existing bookings when new step is added #12878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
CarinaWolli
commented
Dec 19, 2023
| @@ -262,7 +262,7 @@ export const updateHandler = async ({ ctx, input }: UpdateOptions) => { | |||
| }, | |||
| }); | |||
|
|
|||
| const promiseSteps = steps.map(async (step) => { | |||
There was a problem hiding this comment.
steps includes new steps that are not yet created in the DB. That's why it was throwing the foreign key error
| if (addedSteps) { | ||
| const eventTypesToCreateReminders = activeOn.filter( | ||
| (activeEventType) => activeEventType && !newEventTypes.includes(activeEventType) |
There was a problem hiding this comment.
As we don't schedule email reminders for new event types anymore on the new steps, we want to schedule them here, so no need to filter them out
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the error in
workflows/update.handler.tswhen adding a new step to a workflow to and workflow that has active event types.Error:
Type of change
How should this be tested?