Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add DKIM error handling email to cal.ai #12902

Closed
wants to merge 6 commits into from

Conversation

DexterStorey
Copy link
Contributor

What does this PR do?

Handles dkim verification failure with a specific email to the user.

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Dec 20, 2023

@DexterStorey is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

github-actions bot commented Jan 4, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jan 4, 2024
@PeerRich PeerRich added High priority Created by Linear-GitHub Sync cal-ai and removed Stale labels Jan 8, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 11, 2024
Copy link
Contributor

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Jan 23, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 23, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Feb 7, 2024
@keithwillcode
Copy link
Contributor

@DexterStorey Is this something we should still do?

@DexterStorey
Copy link
Contributor Author

Hi @keithwillcode I don't think this is necessary. If there are elevated issues resulting from DKIM we can re-open, but this seems to be rare!

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cal-ai community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync 🚨 merge conflict This PR has a merge conflict that has to be addressed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants