fix: check for isEmbed #12907
Merged
fix: check for isEmbed #12907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
hariombalhara
previously requested changes
Dec 21, 2023
|
also, the need help button only shows up in your own embed if you are the owner of the link |
…ed' into feat/needs-help-embed
PeerRich
reviewed
Dec 29, 2023
Co-authored-by: Peer Richelsen <[email protected]>
keithwillcode
approved these changes
Jan 15, 2024
Current Playwright Test Results Summary✅ 381 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/15/2024 10:37:55am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a1eded6 Started: 01/15/2024 10:30:38am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Short text question Checkbox Group required and Short Text required
Retry 1 • Initial Attempt |
0% (0)0 / 330 runsfailed over last 7 days |
2.12% (7)7 / 330 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 2 • Retry 1 • Initial Attempt |
33.43% (111)111 / 332 runsfailed over last 7 days |
4.82% (16)16 / 332 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
2.56% (9)9 / 351 runsfailed over last 7 days |
15.67% (55)55 / 351 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- future Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0.29% (1)1 / 343 runfailed over last 7 days |
4.96% (17)17 / 343 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 354 runsfailed over last 7 days |
19.49% (69)69 / 354 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
12.75% (45)45 / 353 runsfailed over last 7 days |
84.70% (299)299 / 353 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
4.55% (16)16 / 352 runsfailed over last 7 days |
76.99% (271)271 / 352 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
2.54% (9)9 / 354 runsfailed over last 7 days |
33.90% (120)120 / 354 runsflaked over last 7 days |
hariombalhara
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://discord.com/channels/1125390093386010654/1182022772000555039/1182022772000555039
Hides "needs help" button on embed.