chore: Revert app dir (2) #12916

emrysal · 2023-12-21T15:57:09Z

What does this PR do?

Reverts appDir changes so e2e is closer to passing.

This reverts commit 83a187b.

vercel · 2023-12-21T15:57:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 22, 2023 7:53pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 22, 2023 7:53pm

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Dec 22, 2023 7:53pm
cal	⬜️ Ignored (Inspect)	Visit Preview	Dec 22, 2023 7:53pm
cal-demo	⬜️ Ignored (Inspect)		Dec 22, 2023 7:53pm
qa	⬜️ Ignored (Inspect)		Dec 22, 2023 7:53pm
ui	⬜️ Ignored (Inspect)	Visit Preview	Dec 22, 2023 7:53pm

github-actions · 2023-12-21T15:57:21Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions · 2023-12-21T16:05:44Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`163.36 KB` (🟢 -930 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

deploysentinel · 2023-12-21T16:44:24Z

Current Playwright Test Results Summary

✅ 346 Passing - ❌ 5 Failing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/21/2023 04:54:38pm UTC)

Run Details

Running Workflow Pre-release checks on Github Actions

Commit: ce384d9

Started: 12/21/2023 04:44:01pm UTC

❌ Failures

📄 packages/app-store/googlecalendar/tests/google-calendar.e2e.ts • 3 Failures

Top 1 Common Error Messages

`invalid_grant`	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Google Calendar Test using the primary calendar On reschedule, event should be updated on GCal Retry 2 • Retry 1 • Initial Attempt Error: invalid_grant `invalid_grant`	85.37% (35) 35 / 41 runs failed over last 7 days	4.88% (2) 2 / 41 runs flaked over last 7 days
Google Calendar Test using the primary calendar On new booking, event should be created on GCal Retry 2 • Retry 1 • Initial Attempt Error: invalid_grant `invalid_grant`	85.37% (35) 35 / 41 runs failed over last 7 days	7.32% (3) 3 / 41 runs flaked over last 7 days
Google Calendar Test using the primary calendar When canceling the booking, the GCal event should also be deleted Retry 2 • Retry 1 • Initial Attempt Error: invalid_grant `invalid_grant`	85.37% (35) 35 / 41 runs failed over last 7 days	7.32% (3) 3 / 41 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Org Invitation Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: "rick-1703177091301-domain" Received: ""`	-92.21% (-71) -71 / 77 runs failed over last 7 days	115.58% (89) 89 / 77 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization should be able to create an organization and complete onboarding Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: 1 Received: 0`	18.09% (36) 36 / 199 runs failed over last 7 days	46.73% (93) 93 / 199 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats User can create a seated event (2 seats as example) Retry 1 • Initial Attempt	0% (0) 0 / 194 runs failed over last 7 days	5.15% (10) 10 / 194 runs flaked over last 7 days

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully login flow user & logout using dashboard Retry 1 • Initial Attempt	0.51% (1) 1 / 195 run failed over last 7 days	15.38% (30) 30 / 195 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Paid booking should be able to be rescheduled Retry 2 • Retry 1 • Initial Attempt	1.22% (2) 2 / 164 runs failed over last 7 days	3.66% (6) 6 / 164 runs flaked over last 7 days

📄 apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Insights should be able to go to insights as members Retry 1 • Initial Attempt	1.17% (2) 2 / 171 runs failed over last 7 days	2.34% (4) 4 / 171 runs flaked over last 7 days

📄 apps/web/playwright/embed-code-generator.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose Inline for First Event Type Retry 1 • Initial Attempt	0% (0) 0 / 190 runs failed over last 7 days	6.32% (12) 12 / 190 runs flaked over last 7 days
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose element-click for First Event Type Retry 1 • Initial Attempt	0% (0) 0 / 190 runs failed over last 7 days	4.21% (8) 8 / 190 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	21.32% (42) 42 / 197 runs failed over last 7 days	73.10% (144) 144 / 197 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	0.51% (1) 1 / 197 run failed over last 7 days	82.74% (163) 163 / 197 runs flaked over last 7 days

📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Team Invitation (non verified) Retry 1 • Initial Attempt	6.63% (13) 13 / 196 runs failed over last 7 days	92.35% (181) 181 / 196 runs flaked over last 7 days
Team Invitation (verified) Retry 1 • Initial Attempt	0% (0) 0 / 196 runs failed over last 7 days	97.45% (191) 191 / 196 runs flaked over last 7 days

View Detailed Build Results

keithwillcode · 2023-12-25T02:22:34Z

We’re using scripts to ignore building this until we fix build issues.

emrysal added 2 commits December 21, 2023 15:45

Revert "Revert "fix: temp renamed app dir to prevent OOM""

c5aab13

This reverts commit 83a187b.

revert: App Dir disabled - 404 isn't right

ce384d9

emrysal requested a review from keithwillcode December 21, 2023 15:57

zomars added core area: core, team members only devops labels Dec 21, 2023

vercel bot deployed to Preview – ai December 21, 2023 16:00 View deployment

vercel bot deployed to Preview – api December 21, 2023 16:01 View deployment

vercel bot deployed to Preview – dev December 21, 2023 16:08 View deployment

Merge branch 'main' into chore/revert-appDir-2

a49323f

PeerRich added the Medium priority Created by Linear-GitHub Sync label Dec 22, 2023

vercel bot deployed to Preview – api December 22, 2023 19:49 View deployment

vercel bot deployed to Preview – dev December 22, 2023 19:53 View deployment

keithwillcode closed this Dec 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Revert app dir (2) #12916

chore: Revert app dir (2) #12916

emrysal commented Dec 21, 2023

vercel bot commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading

deploysentinel bot commented Dec 21, 2023 •

edited

Loading

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

keithwillcode commented Dec 25, 2023

chore: Revert app dir (2) #12916

chore: Revert app dir (2) #12916

Conversation

emrysal commented Dec 21, 2023

What does this PR do?

vercel bot commented Dec 21, 2023 • edited Loading

github-actions bot commented Dec 21, 2023 • edited Loading

github-actions bot commented Dec 21, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

🎉 Global Bundle Size Decreased

deploysentinel bot commented Dec 21, 2023 • edited Loading

Current Playwright Test Results Summary

❌ Failures

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

keithwillcode commented Dec 25, 2023

vercel bot commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading

deploysentinel bot commented Dec 21, 2023 •

edited

Loading