Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulk update event type availability #18850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MehulZR
Copy link
Contributor

@MehulZR MehulZR commented Jan 23, 2025

What does this PR do?

Before:

bulk.update.before.mp4

After:

bulk.update.after.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 23, 2025

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 23, 2025
@graphite-app graphite-app bot requested a review from a team January 23, 2025 23:48
@github-actions github-actions bot added event-types area: event types, event-types 🐛 bug Something isn't working labels Jan 23, 2025
@dosubot dosubot bot added the consumer label Jan 23, 2025
Copy link

graphite-app bot commented Jan 23, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/23/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/23/25)

1 label was added to this PR based on Keith Williams's automation.

Comment on lines +139 to +150
if (!values.isDefault || !bulkUpdateEventTypeIds.length) return;

bulkUpdateDefaultAvailabilityMutation.mutate(
{ eventTypeIds: bulkUpdateEventTypeIds },
{
onSuccess: () => {
utils.viewer.availability.list.invalidate();
showToast(t("success"), "success");
},
}
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if it failing, we probably need to handle exceptions 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync consumer event-types area: event types, event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk Update Schedule Not Applying in Detailed Availability View
2 participants