feat(routing-forms): replace FormEdit component with FormBuilder from event-types #19008
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
@oliverqx is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
event-types
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/29/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/29/25)1 label was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (01/31/25)1 reviewer was added to this PR based on Keith Williams's automation. |
parent form expects all form fields under the fields key, not bookingFields
| Page={({ hookForm, form }) => <FormEdit appUrl={appUrl} hookForm={hookForm} form={form} />} | ||
| Page={({ hookForm, form }) => ( | ||
| <> | ||
| {/* <FormEdit appUrl={appUrl} hookForm={hookForm} form={form} /> */} |
There was a problem hiding this comment.
| {/* <FormEdit appUrl={appUrl} hookForm={hookForm} form={form} /> */} |
|
just recorded the loom video edit: loom video outdated |
expected by some tests
1. remove filtering by hard coded values in favour of field.systemOnly 2. return options by value instead of label. return array is used to locate fields, and the test id generation uses values, not label. Included comments to explain my reasoning
…r's dynamic function used to test the previous dynamic, where an accordion was rendered to create and edit fields. Now its a dialog, and data-testids have changed.
FormBuilder does not generate ids for fields, but Routing Forms expects an id.
|
Would it be possible to increase the bounty amount? I’ve been working on adding support for Form Builder fields to Routing Forms widgets, but I just realized that the bounty involves consolidating everything into a single set of custom components. This requires a deep understanding of multiple areas of the codebase—specifically, Form Builder, Routing Forms, and react-awesome-query-builder’s flow—to ensure there are no unintended side effects. Additionally, since the test selectors and form dynamics differ significantly between Routing Forms and Form Builder, I’ll need to update all related playwright tests in Routing Forms (editing the form and rendering of the form). I’ve already put in about 7 hours, and given the complexity, I’d really appreciate a bounty adjustment |
/claim #18987
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
visit routing-forms, edit or create new one.