Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use for UserCreationService for idp signup #19202

Draft
wants to merge 17 commits into
base: use-usercreationservice-for-new-orgs
Choose a base branch
from

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Feb 9, 2025

Stacked on #19201

What does this PR do?

  • Adds GOOGLE and SAML to CreationSource
  • Uses the UserCreationService when creating new users from those sources

https://www.loom.com/share/7f2dbd9202ed4e8abc4c86a7d6a8f2ea?sid=d3bda613-7f5d-4d69-8cb1-0e6909114249

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 4:04am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 4:04am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 4:04am

@joeauyeung joeauyeung changed the base branch from main to use-usercreationservice-for-new-orgs February 10, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants