Add historical capacity extraction #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed an issue where oil generation would have ten times the expected value improved parsing by standardizing grouping methodology improved checkers for unprocessed technology/node combinations
irm-codebase
changed the title
|
Converted to draft while I fix some documentation oddities. |
|
@brynpickering I'd like to request some help with the readthedocs bug triggered by this PR... I've been trying to debug this for a while, but I have not managed to find the source (I'm not very knowledgeable with templating for docs). For what I gather the issue comes from readthedocs directly? |
brynpickering
previously approved these changes
May 7, 2024
src/calliope_pathways/models/italy_stationary/pre_processing/parse_lombardi.py
Outdated
Show resolved
Hide resolved
src/calliope_pathways/models/italy_stationary/data_sources/NUTS_RG_20M_2021_4326.geojson
Outdated
Show resolved
Hide resolved
src/calliope_pathways/models/italy_stationary/pre_processing/parse_lombardi.py
Show resolved
Hide resolved
src/calliope_pathways/models/italy_stationary/pre_processing/parse_lombardi.py
Outdated
Show resolved
Hide resolved
|
@brynpickering Added all your suggestions. Ready for review! |
brynpickering
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11 ... somewhat
Two changes:
powerplantmatching. Unfortunately, this dataset turned out to be quite incomplete overall (Italy is missing 20% of its historical capacity in 2015, MWh storage capacities for pumped hydro are VERY wrong in the dataset). I kept the script in case we want to move the start year or introduce another country. But I trust Lombardi's data more.