refactor: use rest/grpc for the wait strategy

camunda-community-hub · Dec 29, 2024 · 8854c9d · 8854c9d
1 parent 72579c8
commit 8854c9d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/core/src/main/java/io/zeebe/containers/ZeebeTopologyWaitStrategy.java b/core/src/main/java/io/zeebe/containers/ZeebeTopologyWaitStrategy.java
@@ -22,6 +22,7 @@
 import io.camunda.zeebe.client.api.response.BrokerInfo;
 import io.camunda.zeebe.client.api.response.PartitionInfo;
 import io.camunda.zeebe.client.api.response.Topology;
+import java.net.URI;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
@@ -233,11 +234,20 @@ protected void waitUntilReady() {
   }
 
   private ZeebeClient newZeebeClient(final WaitStrategyTarget waitStrategyTarget) {
-    final String gatewayHost = waitStrategyTarget.getHost();
-    final int exposedGatewayPort = waitStrategyTarget.getMappedPort(gatewayPort);
+    //noinspection HttpUrlsUsage
+    final URI gatewayAddress =
+        URI.create(
+            "http://"
+                + waitStrategyTarget.getHost()
+                + ":"
+                + waitStrategyTarget.getMappedPort(gatewayPort));
+
+    // use the same URI for the REST and gRPC address, and rely on the user to correctly set the
+    // port they wish to use
     return clientBuilderProvider
         .get()
-        .gatewayAddress(gatewayHost + ":" + exposedGatewayPort)
+        .restAddress(gatewayAddress)
+        .grpcAddress(gatewayAddress)
         .build();
   }
 

diff --git a/core/src/test/java/io/zeebe/containers/ZeebeTopologyWaitStrategyTest.java b/core/src/test/java/io/zeebe/containers/ZeebeTopologyWaitStrategyTest.java
@@ -26,6 +26,7 @@
 import io.camunda.zeebe.gateway.protocol.GatewayOuterClass.Partition;
 import io.camunda.zeebe.gateway.protocol.GatewayOuterClass.Partition.PartitionBrokerRole;
 import io.camunda.zeebe.gateway.protocol.GatewayOuterClass.TopologyResponse;
+import java.net.URI;
 import java.time.Duration;
 import java.util.Collections;
 import java.util.List;
@@ -70,7 +71,8 @@ final class ZeebeTopologyWaitStrategyTest {
 
   @BeforeEach
   void setup() {
-    Mockito.when(builder.gatewayAddress(Mockito.anyString())).thenReturn(builder);
+    Mockito.when(builder.grpcAddress(Mockito.any())).thenReturn(builder);
+    Mockito.when(builder.restAddress(Mockito.any())).thenReturn(builder);
     Mockito.when(builder.build()).thenReturn(client);
     Mockito.when(client.newTopologyRequest()).thenReturn(topologyRequest);
   }
@@ -132,8 +134,9 @@ void shouldUseCorrectGatewayAddress() {
     strategy.waitUntilReady(target);
 
     // then
-    Mockito.verify(builder, Mockito.timeout(5000).atLeastOnce())
-        .gatewayAddress(target.getHost() + ":" + target.mappedPort);
+    final URI expectedAddress = URI.create("http://" + target.getHost() + ":" + target.mappedPort);
+    Mockito.verify(builder, Mockito.timeout(5000).atLeastOnce()).grpcAddress(expectedAddress);
+    Mockito.verify(builder, Mockito.timeout(5000).atLeastOnce()).restAddress(expectedAddress);
   }
 
   @ParameterizedTest(name = "should timeout on incomplete topology when {0}")