Automate zbchaos release #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to deploy resources to gke and push images to gcr.io we have set up workload federation
go-chaos/release.sh
Outdated
| lastRelease=$(git tag | sort -Vr | head -n1) | ||
|
|
||
| echo "Last release was: $lastRelease" | ||
| read -p "Please type a new release here: " newRelease |
There was a problem hiding this comment.
❌ This won't work when run from GH actions. Maybe allow providing newRelease as an environment variable?
There was a problem hiding this comment.
Thanks good catch, totally forgot about this 😆
There was a problem hiding this comment.
Thanks for checking @oleschoenburg should be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release is now fully automated, you can either run the
./releasescript undergo-chaos/or use the corresponding github action.The release script contains: