Merge pull request #324 from canjs/contains

Render in environments when there is no body element
canjs · Dec 28, 2018 · 3c0d3d5 · 3c0d3d5
2 parents 9edd069 + c08dc9a
commit 3c0d3d5
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/can-component.js b/can-component.js
@@ -601,7 +601,8 @@ var Component = Construct.extend(
 			nodeLists.update(nodeList, getChildNodes(el));
 
 			if(viewModel && viewModel.connectedCallback) {
-				componentInPage = DOCUMENT().body.contains(el);
+				var body = DOCUMENT().body;
+				componentInPage = body && body.contains(el);
 
 				if(componentInPage) {
 					disconnectedCallback = viewModel.connectedCallback(el);

diff --git a/test/component-instantiation-test.js b/test/component-instantiation-test.js
@@ -4,6 +4,7 @@ var QUnit = require("steal-qunit");
 var SimpleMap = require("can-simple-map");
 var stache = require("can-stache");
 var value = require("can-value");
+var globals = require("can-globals");
 
 QUnit.module("can-component instantiation");
 
@@ -331,3 +332,28 @@ QUnit.test("component instantiation is not observable", function(){
 
 	QUnit.equal(count, 1, "only updated once");
 });
+
+QUnit.test("Can render in a document with no body", function() {
+	var doc = document.implementation.createHTMLDocument("Testing");
+	globals.setKeyValue("document", doc);
+
+	doc.documentElement.removeChild(doc.body);
+
+	var ComponentConstructor = Component.extend({
+		tag: "with-no-body",
+		view: "test",
+		ViewModel: {
+			connectedCallback: function() {}
+		}
+	});
+
+	try {
+		new ComponentConstructor();
+		QUnit.ok(true, "rendered without throwing");
+	} catch(e){
+		QUnit.ok(false, "threw" + e.toString());
+	}
+	finally {
+		globals.setKeyValue("document", document);
+	}
+});