Skip to content

Commit

Permalink
typing: add no_implicit_optional lint
Browse files Browse the repository at this point in the history
Explicit optional types are preferred and the default in mypy >= 0.980[1].

Add the config to check for this and fix any instance of the lint error.

References:
[1] https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_optional
  • Loading branch information
aciba90 authored and renanrodrigo committed Jun 18, 2024
1 parent 96d5321 commit f516c73
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 18 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ line_length = 79
[tool.mypy]
check_untyped_defs = "true"
explicit_package_bases = "true"
no_implicit_optional = true

[[tool.mypy.overrides]]
module = [
Expand Down
36 changes: 18 additions & 18 deletions uaclient/entitlements/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
def machine_token(
entitlement_type: str,
*,
affordances: Dict[str, Any] = None,
directives: Dict[str, Any] = None,
overrides: List[Dict[str, Any]] = None,
affordances: Optional[Dict[str, Any]] = None,
directives: Optional[Dict[str, Any]] = None,
overrides: Optional[List[Dict[str, Any]]] = None,
entitled: bool = True,
obligations: Dict[str, Any] = None,
suites: List[str] = None,
additional_packages: List[str] = None
obligations: Optional[Dict[str, Any]] = None,
suites: Optional[List[str]] = None,
additional_packages: Optional[List[str]] = None
) -> Dict[str, Any]:
return {
"resourceTokens": [
Expand Down Expand Up @@ -46,13 +46,13 @@ def machine_token(
def machine_access(
entitlement_type: str,
*,
affordances: Dict[str, Any] = None,
directives: Dict[str, Any] = None,
overrides: List[Dict[str, Any]] = None,
affordances: Optional[Dict[str, Any]] = None,
directives: Optional[Dict[str, Any]] = None,
overrides: Optional[List[Dict[str, Any]]] = None,
entitled: bool = True,
obligations: Dict[str, Any] = None,
suites: List[str] = None,
additional_packages: List[str] = None
obligations: Optional[Dict[str, Any]] = None,
suites: Optional[List[str]] = None,
additional_packages: Optional[List[str]] = None
) -> Dict[str, Any]:
if affordances is None:
affordances = {}
Expand Down Expand Up @@ -96,16 +96,16 @@ def entitlement_factory(tmpdir, FakeConfig, fake_machine_token_file):
def factory_func(
cls,
*,
affordances: Dict[str, Any] = None,
directives: Dict[str, Any] = None,
obligations: Dict[str, Any] = None,
overrides: List[Dict[str, Any]] = None,
affordances: Optional[Dict[str, Any]] = None,
directives: Optional[Dict[str, Any]] = None,
obligations: Optional[Dict[str, Any]] = None,
overrides: Optional[List[Dict[str, Any]]] = None,
entitled: bool = True,
called_name: str = "",
access_only: bool = False,
purge: bool = False,
suites: List[str] = None,
additional_packages: List[str] = None,
suites: Optional[List[str]] = None,
additional_packages: Optional[List[str]] = None,
cfg: Optional[config.UAConfig] = None,
cfg_extension: Optional[Dict[str, Any]] = None,
cfg_features: Optional[Dict[str, Any]] = None,
Expand Down

0 comments on commit f516c73

Please sign in to comment.