Support private github repository

[NobodyXu]

Fixed #1681

[scullionw]

is there anything we can do to help move this forward? maybe testing a build?

[NobodyXu]

is there anything we can do to help move this forward? maybe testing a build?

I just need to spend more time on this, I'm a bit busy recently, but rest asure, I didn't forget it.

[NobodyXu]

Update: I'm a bit busy this week.

cc @scullionw we actually need more contributors for cargo-binstall.

If you are willing to submit a PR, then I can do a code review very quickly.

If you have time, you could pick up where I have left and I'm willing to answer any questions you have related to the codebase.

[NobodyXu]

cc @scullionw This PR is now ready for review, you should be able to download from private repositories using this PR, could you have a try please?

[NobodyXu]

It seems that we have hit the gh token limit for CI, since many tests are run under it.

will apply the suggestion and re-merge it later.

[scullionw]

hi! sorry missed your comment:

i've tried and it doesn't seem to see the release? (it falls back to installing from source)

you can see this in the logs, which matches the screenshot below

DEBUG has_release_artifact{release=GhRelease { repo: GhRepo { owner: "TransitApp", repo: "gtfsRtProcessor" }, tag: "1.2.2" } artifact_name="gtfsrt-analyzer-v1.2.2-aarch64-apple-darwin.tar.gz"}: return=Ok(None)

releases:

full log: https://logpaste.com/UdzdiGd9

[NobodyXu]

@scullionw what is the tag used?

If the tag is not v1.2.2 or 1.2.2, then automatic detection of cargo-binstall would not work, you would need to manually provide pkg-url.

[scullionw]

ah the tag is

basically crate-name + tag.

the issue is that this is a cargo workspace, so there could be more than one binary we want to release

edit: we can work around this for now though, and just release everything at the same time, we'll give it a try! thanks!

[NobodyXu]

the issue is that this is a cargo workspace, so there could be more than one binary we want to release

@scullionw In that case, you can set the repository field in Cargo.toml to https://github.com/TransitApp/gtfsRtProcessor/tree/main/gtfsrt-analyzer

[scullionw]

And the other thing we notice with this PR is that it always asks for the github password (token) whether we provide the github token or not:
with GITHUB_TOKEN

without:

ideally, we would like the user to only have to provide the token once, and then it would be saved? What is your recommendation for this?

ive tried setting git config --global credential.helper osxkeychain to that it remembers but it changes nothing

[NobodyXu]

Oh that's because you are using --git, cargo-binstall currently use gix to clone it, which would require username and password, if you didn't save it.

[NobodyXu]

BTW we have a ticket to support private registry #1693

[scullionw]

Oh that's because you are using --git, cargo-binstall currently use gix to clone it, which would require username and password, if you didn't save it.

cool i will check how to save credentials with gitoxide

[NobodyXu]

cool i will check how to save credentials with gitoxide

I think the default git-config one will work, it is compatible with git

[scullionw]

weird because gix works but not cargo-binstall 🤔

[NobodyXu]

Ohhh I know, it could be that we configured gix to not use system-wide configuration