Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh to handle /boot/firmware/config.txt as well on Raspberry Pi OS Bookworm. #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dygear
Copy link

@Dygear Dygear commented Jul 9, 2024

Answers #209 by checking for the /boot/firmware/config.txt existence, and if found, setting CONFIG_TXT_PATH to it.

Answers cariboulabs#209 by checking for the `/boot/firmware/config.txt` existence, and if found, setting `CONFIG_TXT_PATH` to it.
@jberwald
Copy link

I can confirm that this fix solves the error seen in the Environment Settings stage during installation.

Copy link

@jberwald jberwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully added these lines to my local copy of install.sh. After editing the /boot/firmware/config.txt properly I can confirm that these lines fix the issue with the script not seeing the changes in the config file.

@Dygear
Copy link
Author

Dygear commented Sep 5, 2024

@meexmachina Sorry for the direct mention, but can this get reviewed and pulled?

@geerlingguy
Copy link

FYI this patch was required alongside #176 to get the driver to compile on Pi OS Bookworm, kernel 6.6.y, as of Jan 2025...

@Dygear
Copy link
Author

Dygear commented Jan 28, 2025

As I commented on your video @geerlingguy, this SDR is by far the hardest to implement. It's such a shame as it's sometimes little things like this that make it hard. I would LOVE to see this PR pulled so it makes this a little bit easier.

@great9
Copy link

great9 commented Jan 28, 2025

As I commented on your video @geerlingguy, this SDR is by far the hardest to implement. It's such a shame as it's sometimes little things like this that make it hard. I would LOVE to see this PR pulled so it makes this a little bit easier.

it seems forking is the only option

@Dygear
Copy link
Author

Dygear commented Feb 2, 2025

As I commented on your video @geerlingguy, this SDR is by far the hardest to implement. It's such a shame as it's sometimes little things like this that make it hard. I would LOVE to see this PR pulled so it makes this a little bit easier.

it seems forking is the only option

I hate to say it, but I think you are right. But I for sure do not have time to own a fork of this product at this point. It's not apart of my critical hardware stack. Mostly because the original devs are not supporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants