Add detectEdges flag to determine when the user leaves the edge of the window
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is there a plan to merge this PR ? |
|
hi @carlsednaoui can you please take a look at this PR? |
|
Thanks for the note, Ike. As you can see, I've been a bit absent when it
comes to open source :(
Will try to jump back into the ouibounce train soon!
…On Fri, Feb 17, 2017 at 8:31 AM, Ike Ku ***@***.***> wrote:
hi @carlsednaoui <https://github.com/carlsednaoui> can you please take a
look at this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwVCjOxkyZoPz3_I5iCkOnSrJnRawekks5rdaEhgaJpZM4HsYu->
.
|
|
I know how it happens :) no worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.