Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ouibounce.js to support cookie expiration time #13

Closed
wants to merge 1 commit into from
Closed

Update ouibounce.js to support cookie expiration time #13

wants to merge 1 commit into from

Conversation

ayanev
Copy link

@ayanev ayanev commented Mar 26, 2014

By default the cookie will expire when the session ends.
This will set a new expiration date.

@ayanev
Update ouibounce.js to support cookie expiration time
1444ced 
By default the cookie will expire when the session ends.
This will set a new expiration date.
@carlsednaoui
Copy link
Owner

Thanks for the PR @ayanev! I'll check out the code (and merge) this weekend.

@carlsednaoui
Copy link
Owner

Thanks @Jenius! Passing the cookie expiration date as an option def looks like the right move.

@ayanev, let me know if you want to review/ update the PR.

@carlsednaoui
Copy link
Owner

Added this in commit 2685ba5. Thanks @ayanev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayanev @carlsednaoui @jescalan