pull request per issue #48 (UNTESTED) #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check direction of mouse movement to prevent _enter_ trigger * add better (?) cross-browser event listener, maybe also help with issue?
* included example from http://carlsednaoui.github.io/ouibounce/ * seems that clientY is handled differently between `mousemove` and `mouseleave` events, maybe screenY is better? http://stackoverflow.com/questions/6073505/what-is-the-difference-between-screenx-y-clientx-y-and-pagex-y
* seems that getting the Y coord from screenY differs in `mousemove` vs `mouseleave` * switch from clientY to screenY necessitates changing sensitivity accordingly, since screenY includes browser chrome
|
Also noticed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue?