Add cookieName configuration #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeniau
force-pushed
the
cookieName
branch
2 times, most recently
from
b087a4f to
9b81fe4
Compare
It may be usefull if you want to add multiple ouibounce on different type of pages.
|
@jdeniau, thanks for that cookieName configuration! I'm looking forward to use it. |
|
up? :) |
|
I was just about to suggest this feature! Great work! Looking forward to next release. |
|
Hi everyone, sorry for the delay — been busy / on vacation. Will look and merge soon :) Thanks again for the PR @jdeniau 🍔 |
| @@ -103,7 +104,11 @@ function ouibounce(el, config) { | |||
| cookieDomain = ';domain=' + options.cookieDomain; | |||
| } | |||
|
|
|||
| document.cookie = 'viewedOuibounceModal=true' + cookieExpire + cookieDomain + sitewide; | |||
| if (typeof options.cookieName !== 'undefined') { | |||
There was a problem hiding this comment.
@jdeniau shouldn't this be if (typeof options.cookieName === 'undefined') { use viewedOuibounceModal. Otherwise use options.cookieName?
There was a problem hiding this comment.
You are totally right.
It's fixed.
carlsednaoui
added a commit
that referenced
this pull request
Oct 26, 2014
Add cookieName configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be usefull if you want to add multiple ouibounce on different type of pages.