Manual firing now invokes callback #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tomazzaman I'll take a look this weekend. |
|
You're welcome! |
|
By the way, I've also written a tutorial on using Ouibounce with WordPress: |
carlsednaoui
added a commit
that referenced
this pull request
Jun 14, 2015
Manual firing now invokes callback
|
Damn, nice PR. Thanks @tomazzaman. Let me add your tutorial to the README too 😄 |
|
Thanks, glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a bit of code-housekeeping and introduced jshint, so the build will fail unless the code is well written :) Also introduced an additional test for manual fire.