-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #29
base: main
Are you sure you want to change the base?
Windows support #29
Conversation
@miguelraz, FWIW, this is my (old) attempt to support Windows. |
Int(@ccall kernel32.GetThreadId(thread_handle::THREAD_HANDLE)::DWORD) | ||
end | ||
get_current_threadid() = Int(@ccall kernel32.GetCurrentThreadId()::DWORD) | ||
function get_threadids() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a lil' digging here finally @carstenbauer !
The querying_test.jl
is failing because getcpuids()
is non-deterministic. This function is, however, deterministic (although I don't know yet how to map these numbers to the specific core numbers).
My idea is then to make getcpuid()
be defined as this function is + some handle mapping to get back the proper threadid's.
However, I remember that threadid()
is no longer a recommended way to solve problems. Is that a blocker here? I'm not up to speed on how that could affect these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always use @threads :static for ...
here and then threadid()
is perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this should probably be rebased, because it's somewhat old.
FWIW, after the revamp - which has just landed on the However, I do not plan to work on this at all because I don't care about it enough and, more importantly, don't have access to Windows machines. |
I also don't have access to Windows machines anymore 😢 |
Closes #15