-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode for Android 10+ #158
base: develop
Are you sure you want to change the base?
Conversation
…android 29+, night color scheme for 'light blue' to fix row dividers
Great idea! 👌 🤩 Is it difficult to make it Android 9+? 🤔 |
@Kaligula0 yes, it would be a bit more complicated, with Android 10, there is no need for a specific setting, there is a system flag for the dark mode, and I didn't wrote a full theme, the dark mode convert (almost) all colors by itself. I took the lazy path 😉 |
I'd stick with dark mode for the more recent Android versions only, as usage of older versions than Android 10 should be limited and declining. Furthermore, it keeps this PR simple. |
@erikhuizinga I know, I know… I just love dark mode but my phone development finished on Android 9 🤷 |
It can always be be developed for Android <= 9 (by you? 😉) after this PR is accepted. |
Is this PR still alive? |
Use background color in splash screen,
![Screenshot_1607779471](https://user-images.githubusercontent.com/598526/101985065-d2ce8980-3c85-11eb-97cc-333a5ce3232d.png)
![Screenshot_1607779734](https://user-images.githubusercontent.com/598526/101985137-6c963680-3c86-11eb-8d0f-d10db3659a3d.png)
Add force dark allowed for Android API 29+ (follows the user theme)
Night color scheme for 'light blue' to fix row dividers