Use decimal instead of hexadecimal notation for "editbin" command #4241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#4231
Follow-Up to #3986
Summary:
editbin /STACK:
command, to work-around a regression introduced in editbin v14.33 (and possibly 14.32 or 14.31) that no longer recognizes the0x...
hex format.Changes:
editbin
command line inCefSharp.BrowserSubprocess.csproj
andCefSharp.BrowserSubprocess.netcore.csproj
to specify/STACK:8388608
instead of/STACK:0x800000
for theeditbin
command, which works with editbin v14.33.How Has This Been Tested?
dumpbin /headers
that before the change, forCefSharp.BrowserSubprocess.exe
it showed0 size of stack reserve
, and after the change it showed800000 size of stack reserve
for thex64
andarm64
binaries.(Note: For testing
arm64
, I needed to change theTargetFramework
ofCefSharp.BrowserSubprocess.Core
fromnetcoreapp3.1
tonet5.0
, due to the build error described in Feature Request - Add .Net 5.0 Support #3284 (comment) with VS 2022.)Screenshots (if appropriate):
Types of changes
Checklist: