Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decimal instead of hexadecimal notation for "editbin" command #4241

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

kpreisser
Copy link
Contributor

@kpreisser kpreisser commented Sep 7, 2022

Fixes:
#4231

Follow-Up to #3986

Summary:

  • Use decimal instead of hexadecimal notation for the editbin /STACK: command, to work-around a regression introduced in editbin v14.33 (and possibly 14.32 or 14.31) that no longer recognizes the 0x... hex format.

Changes:

  • I modified the editbin command line in CefSharp.BrowserSubprocess.csproj and CefSharp.BrowserSubprocess.netcore.csproj to specify /STACK:8388608 instead of /STACK:0x800000 for the editbin command, which works with editbin v14.33.

How Has This Been Tested?

  • Built the projects using Visual Studio 2022 Version 17.3.3, and verified with dumpbin /headers that before the change, for CefSharp.BrowserSubprocess.exe it showed 0 size of stack reserve, and after the change it showed 800000 size of stack reserve for the x64 and arm64 binaries.
    (Note: For testing arm64, I needed to change the TargetFramework of CefSharp.BrowserSubprocess.Core from netcoreapp3.1 to net5.0, due to the build error described in Feature Request - Add .Net 5.0 Support #3284 (comment) with VS 2022.)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

…he "editbin /STACK:" command, to work-around a regression introduced in editbin v14.33 (and possibly 14.32 or 14.31) that no longer recognizes the "0x..." hex format.

See cefsharp#4231
@AppVeyorBot
Copy link

@amaitland amaitland merged commit 8a2c1cc into cefsharp:master Sep 7, 2022
@amaitland
Copy link
Member

Thanks 👍

@kpreisser kpreisser deleted the fixEditbinStackSize branch September 7, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants