Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enhance clarity in comment for function name #23

Merged
merged 4 commits into from
Jan 22, 2024
Merged

chore: enhance clarity in comment for function name #23

merged 4 commits into from
Jan 22, 2024

Conversation

hoank101
Copy link
Contributor

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@hoank101 hoank101 requested review from a team as code owners January 22, 2024 16:16
@hoank101 hoank101 requested review from staheri14, ninabarbakadze, ramin and vgonkivs and removed request for a team January 22, 2024 16:16
@celestia-bot celestia-bot requested review from a team January 22, 2024 16:17
ninabarbakadze
ninabarbakadze reviewed Jan 22, 2024
View reviewed changes
merkle/proof_op.go Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team January 22, 2024 16:38
ninabarbakadze
ninabarbakadze approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

rootulp
rootulp approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It would be nice if we had a linter that caught these instances where the first word in the comment doesn't match the function name.

@rootulp rootulp merged commit ad044a7 into celestiaorg:main Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninabarbakadze ninabarbakadze ninabarbakadze approved these changes

@rootulp rootulp rootulp approved these changes

@staheri14 staheri14 Awaiting requested review from staheri14 staheri14 is a code owner automatically assigned from celestiaorg/celestia-core

@ramin ramin Awaiting requested review from ramin ramin is a code owner automatically assigned from celestiaorg/celestia-node

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner automatically assigned from celestiaorg/celestia-node

Assignees
No one assigned
Labels
external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoank101 @rootulp @ninabarbakadze