Merge pull request #8697 from cfpb/tccp/protect-situations

Return an empty list for tccp situations when invalid data gets cleaned

cfgov/tccp/tests/test_views.py

@@ -84,6 +84,10 @@ def test_no_querystring_filters_by_good_tier(self):
         self.assertContains(response, "Consumer Financial Protection Bureau")
         self.assertContains(response, "There are no results for your search.")
 
+    def test_invalid_situations(self):
+        response = self.make_request("?situations=fake+and+bad")
+        self.assertContains(response, "There are no results for your search.")
+
     def test_htmx_includes_only_results(self):
         response = self.make_request(**{"HTTP_HX-Request": "true"})
         self.assertNotContains(

cfgov/tccp/views.py

@@ -145,7 +145,7 @@ def list(self, request, *args, **kwargs):
         # If we're rendering HTML, we need to augment the response context.
         if render_format == "html":
             form = filter_backend.used_filterset.form
-            situations = form.cleaned_data["situations"]
+            situations = form.cleaned_data.get("situations", [])
 
             purchase_apr_rating_ranges = self.get_purchase_apr_rating_ranges(
                 cards