Fix incorrect Python tests using mock.called_with #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This followup to PR 8711 fixes various Python tests that are incorrectly trying to call `called_with` on a mock object, when the correct call is `assert_called_with` [0]. Most of these tests are in the Paying for College disclosures code, and one is in iRegulations. Currently these tests don't actually test anything, as `assertTrue(something that is truthy)` does nothing. [0] https://docs.python.org/3.8/library/unittest.mock.html#unittest.mock.Mock.assert_called_with
12 tasks
wpears
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This followup to #8711 fixes various Python tests that are incorrectly trying to call
called_withon a mock object, when the correct call isassert_called_with.Most of these tests are in the Paying for College disclosures code, and one is in iRegulations.
Currently these tests don't actually test anything, as
assertTrue(something that is truthy)does nothing.Checklist