Fixing multi value headers so they are serialized correctly #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradtalabat
changed the title
gerfalcon
approved these changes
Nov 8, 2022
| @@ -74,6 +74,17 @@ Future<void> startServer() async { | |||
| return; | |||
| } | |||
|
|
|||
| if (path == '/multi-value-header') { | |||
| response.headers.contentType = ContentType('application', 'json'); | |||
| response.headers.add("x-multi-value-request-header-echo", request.headers.value("x-multi-value-request-header").toString()); | |||
There was a problem hiding this comment.
Please, use single quotes here like this:
response.headers.add('x-multi-value-request-header-echo', request.headers.value('x-multi-value-request-header').toString());
6 tasks
|
Hi everyone! We've made our hardfork repo public and published a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
developto avoid conflicts (via merge from master or rebase)This merge request fixes / refers to the following issues: There was a change in version 4.0.1 that converted request header to their string values. This breaks multi value request headers as the get serialized like this
[value1,value2]instead of like thisvalue1,value2Pull Request Description
Change has been made to use the previous code, which worked in 4.0.0. This bug was found after upgrading from 4.0.0 to 4.0.6