Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dio): Allow ResponseDecoder and RequestEncoder to be async #2015

Merged
merged 10 commits into from
Nov 10, 2023
Merged

feat(dio): Allow ResponseDecoder and RequestEncoder to be async #2015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a41f9c9
feat(http2_adapter): handle gzip
Reprevise Oct 25, 2023
59b69b9
feat(dio): Allow ResponseDecoder to return a Future<String?>
Reprevise Oct 30, 2023
2228b04
add tests, and conditionally await FutureOr<String?>
Reprevise Oct 31, 2023
0a847cf
Merge branch 'main' into feature/response-decoder-future
Reprevise Oct 31, 2023
331a96f
Merge branch 'main' into feature/response-decoder-future
Reprevise Nov 2, 2023
a48d9e9
Merge branch 'main' into feature/response-decoder-future
Reprevise Nov 9, 2023
4a81185
Allow RequestEncoder to return Future<List<int>>
Reprevise Nov 9, 2023
70d52cf
Merge branch 'main' into feature/response-decoder-future
Reprevise Nov 9, 2023
7a1b46a
Revert "Merge branch 'main' into feature/response-decoder-future"
Reprevise Nov 9, 2023
19d6e84
Update CHANGELOG.md
Reprevise Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dio/lib/src/options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:async';

import 'package:meta/meta.dart';

import 'adapter.dart';
Expand Down Expand Up @@ -76,7 +78,7 @@ enum ListFormat {
typedef ValidateStatus = bool Function(int? status);

/// The type of a response decoding callback.
typedef ResponseDecoder = String? Function(
typedef ResponseDecoder = FutureOr<String?> Function(
List<int> responseBytes,
RequestOptions options,
ResponseBody responseBody,
Expand Down
2 changes: 1 addition & 1 deletion dio/lib/src/transformers/sync_transformer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class SyncTransformer extends Transformer {
);
final String? response;
if (options.responseDecoder != null) {
response = options.responseDecoder!(
response = await options.responseDecoder!(
Reprevise marked this conversation as resolved.
Show resolved Hide resolved
responseBytes,
options,
responseBody..stream = Stream.empty(),
Expand Down