This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Use Durations instead of ints for timeouts
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dio/lib/src/adapters/browser_adapter.dart # dio/lib/src/adapters/io_adapter.dart # dio/lib/src/options.dart # dio/test/readtimeout_test.dart migrate http2 adapter # Conflicts: # plugins/http2_adapter/example/example.dart use stopwatches # Conflicts: # dio/lib/src/adapters/io_adapter.dart fix durations PR Feedback Update docs
ueman
changed the title
Durations instead of ints.Durations instead of ints for timeouts
AlexV525
reviewed
Nov 4, 2022
No, it didn't but I'll add it |
|
@AlexV525 Speak some questions. Maybe we should translate existed comments in English? |
Yeah sure. We can to fix them all in one another PR. |
AlexV525
approved these changes
Nov 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added in cfug/dio#1376
This changes the use of
ints toDurations. This makes it more ergonomic to use timeouts, since the units are now enforced statically.This is in preparation for landing cfug/dio#1405, since it depends on a couple of changes which were previously landed in the v5 branch of the original dio repository.
This is a breaking change