Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup karma and rollup #52

Merged
merged 3 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build
name: Test

on:
pull_request:
Expand All @@ -7,36 +7,33 @@ on:
- main

jobs:
build:
name: Build
test:
name: Test
runs-on: ubuntu-latest
steps:
- name: Get sources
uses: actions/checkout@v1
uses: actions/checkout@v4

- name: Restore npm cache
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- uses: actions/cache@v2
- uses: actions/cache@v4
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-modules-
- name: Use Node.js 16
uses: actions/setup-node@v3
- name: Use Node.js 22
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: "22"

- name: Install dependencies
run: npm install

- name: Build
run: npm run build --if-present
run: npm ci

- name: Test
run: npm run test
Expand Down
19 changes: 0 additions & 19 deletions karma.conf.cjs

This file was deleted.

128 changes: 0 additions & 128 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@
"url": "git+ssh://[email protected]/chaijs/check-error.git"
},
"scripts": {
"build": "rollup -c rollup.config.js",
"lint": "eslint --ignore-path .gitignore index.js test/",
"prepublish": "npm run build",
"semantic-release": "semantic-release pre && npm publish && semantic-release post",
"pretest": "npm run lint && npm run build",
"pretest": "npm run lint",
"test": "npm run test:node && npm run test:browser",
"test:browser": "web-test-runner",
"test:node": "mocha"
Expand Down Expand Up @@ -58,8 +56,6 @@
}
},
"devDependencies": {
"@rollup/plugin-commonjs": "^21.0.0",
"@rollup/plugin-node-resolve": "^13.0.5",
"@web/test-runner": "^0.17.0",
"browserify": "^13.0.0",
"browserify-istanbul": "^1.0.0",
Expand All @@ -68,7 +64,6 @@
"eslint-plugin-filenames": "^0.2.0",
"ghooks": "^1.0.1",
"mocha": "^9.1.2",
"rollup": "^2.58.0",
"semantic-release": "^4.3.5",
"simple-assert": "^2.0.0",
"validate-commit-msg": "^2.3.1"
Expand Down
11 changes: 0 additions & 11 deletions rollup.config.js

This file was deleted.