-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MilkyWay #903
Add MilkyWay #903
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Could you please rewrite the information based on the README? You can test the code in your local environment and see how to do it on the README.
cosmos/milkyway.json
Outdated
"coinDenom": "MILK", | ||
"coinMinimalDenom": "umilk", | ||
"coinDecimals": 6, | ||
"coinGeckoId": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it if there's no available CoinGecko id.
cosmos/milkyway.json
Outdated
"walletUrl": "https://beta.milkyway.zone/", | ||
"walletUrlForStaking": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two lines. walletUrl is deprecated and walletUrlForStaking shouldn't be empty.
cosmos/milkyway.json
Outdated
"coinDenom": "stTIA", | ||
"coinMinimalDenom": "umilk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The denom and the minimal denom don't seem to match
cosmos/milkyway.json
Outdated
"coinDenom": "stTIA", | ||
"coinMinimalDenom": "umilk", | ||
"coinDecimals": 6, | ||
"coinGeckoId": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line as well.
cosmos/milkyway.json
Outdated
"coinMinimalDenom": "umilk", | ||
"coinDecimals": 6, | ||
"coinGeckoId": "", | ||
"coinImageUrl": "ibc/8D4FC51F696E03711B9B37A5787FB89BD2DDBAF788813478B002D552A12F9157", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a url.
images/milkyway/chain.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image sizes should be 256*256px.
cosmos/milkyway.json
Outdated
{ | ||
"coinDenom": "TIA", | ||
"coinMinimalDenom": "ibc/6C349F0EB135C5FA99301758F35B87DB88403D690E5E314AB080401FEE4066E5", | ||
"coinDecimals": 6, | ||
"coinGeckoId": "celestia", | ||
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/celestia/chain.png", | ||
"gasPriceStep": { | ||
"low": 0.0025, | ||
"average": 0.003, | ||
"high": 0.004 | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not duplicated, we simply have two versions of TIA supported inside our chain: one that is bridged through Osmosis, and the other ones that is bridged through Celestia directly. We support both as our fee tokens.
Adds
milkyway
chain information