Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MilkyWay #903

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

RiccardoM
Copy link
Contributor

Adds milkyway chain information

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 2:40am

Copy link
Collaborator

@editaahn editaahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Could you please rewrite the information based on the README? You can test the code in your local environment and see how to do it on the README.

"coinDenom": "MILK",
"coinMinimalDenom": "umilk",
"coinDecimals": 6,
"coinGeckoId": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it if there's no available CoinGecko id.

Comment on lines 18 to 19
"walletUrl": "https://beta.milkyway.zone/",
"walletUrlForStaking": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two lines. walletUrl is deprecated and walletUrlForStaking shouldn't be empty.

Comment on lines 99 to 100
"coinDenom": "stTIA",
"coinMinimalDenom": "umilk",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The denom and the minimal denom don't seem to match

"coinDenom": "stTIA",
"coinMinimalDenom": "umilk",
"coinDecimals": 6,
"coinGeckoId": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line as well.

"coinMinimalDenom": "umilk",
"coinDecimals": 6,
"coinGeckoId": "",
"coinImageUrl": "ibc/8D4FC51F696E03711B9B37A5787FB89BD2DDBAF788813478B002D552A12F9157",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a url.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image sizes should be 256*256px.

Comment on lines 74 to 85
{
"coinDenom": "TIA",
"coinMinimalDenom": "ibc/6C349F0EB135C5FA99301758F35B87DB88403D690E5E314AB080401FEE4066E5",
"coinDecimals": 6,
"coinGeckoId": "celestia",
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/celestia/chain.png",
"gasPriceStep": {
"low": 0.0025,
"average": 0.003,
"high": 0.004
}
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not duplicated, we simply have two versions of TIA supported inside our chain: one that is bridged through Osmosis, and the other ones that is bridged through Celestia directly. We support both as our fee tokens.

@editaahn editaahn merged commit 77b29fe into chainapsis:main Dec 9, 2024
3 checks passed
@RiccardoM RiccardoM deleted the riccardom/add-milkyway branch January 15, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants