addNdefListener not calling callback on first attempt #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX for issue 217: addNdefListener not calling callback on first attempt I don't know why the Intent contains the ACTION_NDEF_DISCOVERED when reading non-MIME NDEF records the first time. After the first read, the action contains the ACTION_TECH_DISCOVERED as expected. Even if this behavior were not the plugin's fault, it does make sense to fire the "ndef" event when reading MIME records in adition to the "ndef-mime" event, because if we have registered a callback with `addNdefListener`, then we want to be called back on every subtype of NDEF record.
Closed
|
Can this pull request be merged please, this is really an annoying bug.. Thx! |
|
This fixes the symptom but causes 2 events to be fired causing problems when an app uses both addNdefListener and addMimeTypeListener. I think I've tracked this problem down. See #217 (comment) for more details. |
|
Thanks for the pull request. I'm closing this because the problem is fixed by #324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX for issue 217: addNdefListener not calling callback on first attempt
I don't know why the Intent contains the ACTION_NDEF_DISCOVERED when reading non-MIME NDEF records the first time.
After the first read, the action contains the ACTION_TECH_DISCOVERED as expected.
Even if this behavior were not the plugin's fault, it does make sense to fire the "ndef" event when reading MIME records in adition to the "ndef-mime" event, because if we have registered a callback with
addNdefListener, then we want to be called back on every subtype of NDEF record.