Remove not supported Peer2Peer NFC communication for Android on SDK 34 support #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFC java file changes for SDK >31
Set intent flag to mutable
Update code so it works with iOS16.4
1.2.0 j5.1
ghost
changed the title
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface for Peer2Peer communication (Beam NDEF messages to other devices) has been deprecated since SDK 10 since there is another way to do it. In Android SDK 34 they removed the interface and so prevents the apk to build due to not existing
symbolsWe don't use that interface at all so I decided to simple commented it out for Android so the app builds again
Increased the version to 1.2.0-j5.2