Deprecate InstanceBuilder::set_minimum_instance_version, add InstanceBuilder::force_api_version, add SystemInfo::iis_instance_version_available #351
+121
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
charles-lunarg
commented
Feb 18, 2025
charles-lunarg
commented
- Add vkb::SystemInfo::is_instance_version_available
- Add InstanceBuilder::force_api_version
- Deprecate InstanceBuilder::set_minimum_instance_version
Allows users to check the Instance API version before calling vkb::InstanceBuilder::build().
set_minimum_instance_version
This adds the ability for applications to set a specific API version irrespective of the available Instance API version. This is useful when application intends to use Physical Devices which are newer than the Instance. api_versions specified by force_api_version() are propagated to Physical Device selection as the minimum version.
DethRaid
reviewed
Feb 18, 2025
| @@ -819,6 +835,14 @@ InstanceBuilder& InstanceBuilder::set_minimum_instance_version(uint32_t major, u | |||
| info.minimum_instance_version = VKB_MAKE_VK_VERSION(0, major, minor, patch); | |||
| return *this; | |||
| } | |||
| InstanceBuilder& InstanceBuilder::force_api_version(uint32_t major, uint32_t minor) { | |||
There was a problem hiding this comment.
I don't have any meaningful suggestions so I'll bikeshed the name
What about set_api_version? force_api_version makes so... forceful
There was a problem hiding this comment.
This use case is kinda "advanced" API usage, so a scary name helps ward away unsuspecting users.
spencer-lunarg
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.