Skip to content

v1.0.9 Fix handling of disk roots on Windows

Latest
Compare
Choose a tag to compare
@charlievieth charlievieth released this 25 Oct 14:39
· 3 commits to master since this release

v1.0.9

This release fixes an issue on Windows that occured when the root argument to Walk was a disk root (C:\). Instead of walking the disk root C:\ (or any other root) it walked the current directory. This occurred because we were transforming fully qualified path C:\ to the relative path C: which caused the current directory to be walked.

commit aa71a4c
Author: Charlie Vieth [email protected]
Date: Fri Oct 25 10:10:04 2024 -0400

fastwalk: don't clean the path argument to Walk on Windows

On Windows don't attempt to clean the path argument to Walk since the
existing clean logic (cleanRootPath) transforms paths like "C:\" => "C:"
which are not equivalent.

This logic only existed to make the joining of paths simpler and should
probably be removed since we shouldn't be modifying user provided paths.

TODO: Investigate if anything relies on the current clean logic and
remove it if nothing does.

Fixes: https://github.com/charlievieth/fastwalk/issues/37