Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About _site folder #31

Open
whalekeykeeper opened this issue Nov 1, 2024 · 3 comments
Open

About _site folder #31

whalekeykeeper opened this issue Nov 1, 2024 · 3 comments

Comments

@whalekeykeeper
Copy link
Collaborator

Since we are using GitHub Pages, we can directly configure it to build our site from the main branch or a dedicated branch without needing to commit the _site folder.
Shall we add it into .gitignore?

whalekeykeeper added a commit that referenced this issue Nov 1, 2024
whalekeykeeper added a commit that referenced this issue Nov 1, 2024
@damianodamiani
Copy link
Collaborator

hey sure, if that won't impact on the website usability then def!

@whalekeykeeper
Copy link
Collaborator Author

whalekeykeeper commented Nov 15, 2024

hey sure, if that won't impact on the website usability then def!

In theory, it would be the best practice to remove it and add the path into .gitignore.

Whenever we run jeykll build locally, Jeykll compiles all our sources files and generates the complete static website in this directory.

Then, remotely, whenever we push something to our repository (main branch), GitHub Pages will automatically build our Jeykll site to recreate the content in this directory. Not to say that sometimes more than one person are working on this project.

Therefore, including this directory/folder makes the repository size larger unnecessarily and especially it may cause merge conflicts.

So, yeah, I think it is better that I go to add it to the PR draft.

@damianodamiani
Copy link
Collaborator

OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants