Auto hide dropdown menu #32
Conversation
Fixed a misplaced closing parenthesis.
1. add the script for hiding dropdown menu 2. use relative_url instead of absolute_url 3. add CSS code for hiding dropdown menu
update gitignore
update url
Fixed a misplaced closing parenthesis.
1. add the script for hiding dropdown menu 2. use relative_url instead of absolute_url 3. add CSS code for hiding dropdown menu see #15
update gitignore
update url
…x/chinacomx.github.io into auto-hide-dropdown-menu
|
The dropdown menu hiding feature is successfully added. Though a issue were just found in this branch: when clicking on "Team" or "About" and so on with a PC browser, with the local server, the entire menu part is gone, which is not the case for the current deployed version. I have a guess. Gonna have a look in the next a few days. |
|
hi Qin! thanks for looking into that. I am not sure what Lena told you, but basically the website as it is now works great on computer screens -- it does not, however, on mobile. I essentially wrote the whole page from zero with some GPT help, so for sure there some weird solutions, and that's also why the mobile version didn't really work. I tried implementing some exisitng frameworks via gh pages or other prewritten packages, but none works with the page. hope you will have some ideas! My approach would be to either a) make the mobile version be the same as the regular, just with the menu as a dorpdwon etc, or b) make the website recognize its on mobile and load a separate verison, that is much simplified and works specifically on mobile. What do you think? + also any suggestions for the website are welcomed! I am working now on a TEAM page, could also brainstorm that together if you want :) |
I totally agree with you that to take mobile devices or smaller screens into consideration is actually quite necessary. Many people are using tablets and mobile phones. And it is amazing how much you have already designed and built up! From my view, a) will be simpler. And that's what I was trying to do. I will have another look later today and come back here. For TEAM page, if you have any idea, just bring it up, I am not particularly an expert on frontend, but 众人拾柴火焰高 or 人多力量大 (actually the first one jumped into my head is 三个臭皮匠，顶过诸葛亮 haha), therefore, if you have any ideas/questions, feel free to open issues/write me/set up a meeting or whatever. |
|
OK! lets focus first on the mobile page rendering, the team page can come after :) |
There are a few changes:
_includes/header.htmlto avoid using local host url, for example,href="/contact/"instead ofhref="http://localhost:4000/contact/"_siteteam.mdChecked in the following ways:
bundle exec jekyll serveon terminal and examine the given server address to see if the dropdown menu could hide automatically.bundle exec jekyll serve --host 0.0.0.0to bind the server to local machine’s IP address and make the website accessible on local network, then use something like http://192.168.1.10:4000/ (replace 192.168.1.10 with the correct computer's IP address) on mobile device to double check if the dropdown menu could hide automatically.see #31 #15