Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #16] Added unit test based on the sample. #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Issue #16] Added unit test based on the sample. #17

wants to merge 1 commit into from

Conversation

scr
Copy link

@scr scr commented Mar 13, 2016

Issue #16

@scr scr force-pushed the add-gtest branch 3 times, most recently from 7e8897d to e54017a Compare March 13, 2016 18:50
@cynthia cynthia self-requested a review June 4, 2019 11:55
@cynthia
Copy link
Collaborator

cynthia commented Jun 4, 2019

Thank you for the patch. (And apologies that this took so long)

This seems like a useful addition, but it implies that googletest is already checked out somehow, which would confuse users; and I don't see a submodule dependency added in here. Can you describe what you had in mind here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynthia cynthia Awaiting requested review from cynthia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scr @cynthia